lucasbru commented on code in PR #17695:
URL: https://github.com/apache/kafka/pull/17695#discussion_r1831147309
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java:
##########
@@ -627,6 +626,99 @@ private List<TaskIds> convertTaskIdCollection(final
Set<StreamsAssignmentInterfa
.collect(Collectors.toList());
}
+ private List<StreamsGroupHeartbeatRequestData.Subtopology>
getTopologyFromStreams() {
+ final Map<String, StreamsAssignmentInterface.Subtopology>
subTopologyMap = streamsInterface.subtopologyMap();
+ final List<StreamsGroupHeartbeatRequestData.Subtopology>
subtopologies = new ArrayList<>(subTopologyMap.size());
+ for (final Map.Entry<String,
StreamsAssignmentInterface.Subtopology> subtopology :
subTopologyMap.entrySet()) {
+
subtopologies.add(getSubtopologyFromStreams(subtopology.getKey(),
subtopology.getValue()));
+ }
+ return subtopologies;
+ }
+
+ private static StreamsGroupHeartbeatRequestData.Subtopology
getSubtopologyFromStreams(final String subtopologyName,
+
final StreamsAssignmentInterface.Subtopology subtopology) {
+ final StreamsGroupHeartbeatRequestData.Subtopology subtopologyData
= new StreamsGroupHeartbeatRequestData.Subtopology();
+ subtopologyData.setSubtopologyId(subtopologyName);
+ ArrayList<String> sortedSourceTopics = new
ArrayList<>(subtopology.sourceTopics);
+ Collections.sort(sortedSourceTopics);
+ subtopologyData.setSourceTopics(sortedSourceTopics);
+ ArrayList<String> sortedSinkTopics = new
ArrayList<>(subtopology.repartitionSinkTopics);
+ Collections.sort(sortedSinkTopics);
+ subtopologyData.setRepartitionSinkTopics(sortedSinkTopics);
+
subtopologyData.setRepartitionSourceTopics(getRepartitionTopicsInfoFromStreams(subtopology));
+
subtopologyData.setStateChangelogTopics(getChangelogTopicsInfoFromStreams(subtopology));
+ subtopologyData.setCopartitionGroups(
+ getCopartitionGroupsFromStreams(subtopology.copartitionGroups,
subtopologyData));
+ return subtopologyData;
+ }
+
+ private static List<CopartitionGroup> getCopartitionGroupsFromStreams(
+ final Collection<Set<String>> copartitionGroups,
+ final StreamsGroupHeartbeatRequestData.Subtopology
subtopologyData) {
Review Comment:
Done
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java:
##########
@@ -627,6 +626,99 @@ private List<TaskIds> convertTaskIdCollection(final
Set<StreamsAssignmentInterfa
.collect(Collectors.toList());
}
+ private List<StreamsGroupHeartbeatRequestData.Subtopology>
getTopologyFromStreams() {
+ final Map<String, StreamsAssignmentInterface.Subtopology>
subTopologyMap = streamsInterface.subtopologyMap();
+ final List<StreamsGroupHeartbeatRequestData.Subtopology>
subtopologies = new ArrayList<>(subTopologyMap.size());
+ for (final Map.Entry<String,
StreamsAssignmentInterface.Subtopology> subtopology :
subTopologyMap.entrySet()) {
+
subtopologies.add(getSubtopologyFromStreams(subtopology.getKey(),
subtopology.getValue()));
+ }
+ return subtopologies;
+ }
+
+ private static StreamsGroupHeartbeatRequestData.Subtopology
getSubtopologyFromStreams(final String subtopologyName,
+
final StreamsAssignmentInterface.Subtopology subtopology) {
+ final StreamsGroupHeartbeatRequestData.Subtopology subtopologyData
= new StreamsGroupHeartbeatRequestData.Subtopology();
+ subtopologyData.setSubtopologyId(subtopologyName);
+ ArrayList<String> sortedSourceTopics = new
ArrayList<>(subtopology.sourceTopics);
+ Collections.sort(sortedSourceTopics);
+ subtopologyData.setSourceTopics(sortedSourceTopics);
+ ArrayList<String> sortedSinkTopics = new
ArrayList<>(subtopology.repartitionSinkTopics);
+ Collections.sort(sortedSinkTopics);
+ subtopologyData.setRepartitionSinkTopics(sortedSinkTopics);
+
subtopologyData.setRepartitionSourceTopics(getRepartitionTopicsInfoFromStreams(subtopology));
+
subtopologyData.setStateChangelogTopics(getChangelogTopicsInfoFromStreams(subtopology));
+ subtopologyData.setCopartitionGroups(
+ getCopartitionGroupsFromStreams(subtopology.copartitionGroups,
subtopologyData));
+ return subtopologyData;
+ }
+
+ private static List<CopartitionGroup> getCopartitionGroupsFromStreams(
+ final Collection<Set<String>> copartitionGroups,
+ final StreamsGroupHeartbeatRequestData.Subtopology
subtopologyData) {
+
+ final Map<String, Short> sourceTopicsMap =
+ IntStream.range(0, subtopologyData.sourceTopics().size())
+ .boxed()
+
.collect(Collectors.toMap(subtopologyData.sourceTopics()::get,
Integer::shortValue));
+
+ final Map<String, Short> repartitionSourceTopics =
+ IntStream.range(0,
subtopologyData.repartitionSourceTopics().size())
+ .boxed()
+ .collect(
+ Collectors.toMap(x ->
subtopologyData.repartitionSourceTopics().get(x).name(),
+ Integer::shortValue));
+
+ return copartitionGroups.stream()
+ .map(x -> getCopartitionGroupFromStreams(x, sourceTopicsMap,
repartitionSourceTopics))
+ .collect(Collectors.toList());
+ }
+
+ private static CopartitionGroup getCopartitionGroupFromStreams(
+ final Set<String> topicNames,
+ final Map<String, Short> sourceTopicsMap,
+ final Map<String, Short> repartitionSourceTopics) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
