fvaleri commented on code in PR #17524:
URL: https://github.com/apache/kafka/pull/17524#discussion_r1833121173
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -615,6 +615,30 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
assertEquals(brokerStrs.mkString(","), nodeStrs.mkString(","))
}
+ @ParameterizedTest
+ @ValueSource(strings = Array("kraft"))
+ def testListNodesWithFencedBroker(quorum: String): Unit = {
+ client = createAdminClient
+ val fencedBrokerId = brokers.last.config.brokerId
+ killBroker(fencedBrokerId)
+ // It takes a few seconds for a broker to get fenced after being killed
+ // So we retry until only 2 of 3 brokers returned in the result or the max
wait is reached
+ TestUtils.retry(20000) {
Review Comment:
I think this is ok, because the fencing time should be around
`broker.session.timeout.ms` (9 seconds) in the worst case.
https://github.com/apache/kafka/blob/trunk/metadata/src/main/java/org/apache/kafka/controller/QuorumController.java#L1650-L1662
One thing we can improve is the to kill the broker immediately:
```sh
killBroker(fencedBrokerId, JDuration.ofMillis(0))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
