dajac commented on code in PR #17750:
URL: https://github.com/apache/kafka/pull/17750#discussion_r1838496483
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -14979,6 +14980,83 @@ public void
testReplayConsumerGroupRegularExpressionTombstone() {
);
}
+ @Test
+ public void
testConsumerGroupMemberPicksUpExistingResolvedRegularExpression() {
+ String groupId = "fooup";
+ String memberId1 = Uuid.randomUuid().toString();
+ String memberId2 = Uuid.randomUuid().toString();
+
+ Uuid fooTopicId = Uuid.randomUuid();
+ String fooTopicName = "foo";
+
+ ConsumerGroupPartitionAssignor assignor =
mock(ConsumerGroupPartitionAssignor.class);
+ when(assignor.name()).thenReturn("range");
+ when(assignor.assign(any(), any())).thenAnswer(answer -> {
+ GroupSpec spec = answer.getArgument(0);
+
+ List.of(memberId1, memberId2).forEach(memberId ->
+ assertEquals(
+ Collections.singleton(fooTopicId),
+ spec.memberSubscription(memberId).subscribedTopicIds(),
+ String.format("Member %s has unexpected subscribed topic
ids", memberId)
+ )
+ );
+
+ return new GroupAssignment(Map.of(
+ memberId1, new MemberAssignmentImpl(mkAssignment(
+ mkTopicAssignment(fooTopicId, 0)
+ )),
+ memberId2, new MemberAssignmentImpl(mkAssignment(
+ mkTopicAssignment(fooTopicId, 1)
+ ))
+ ));
+ });
+
+ GroupMetadataManagerTestContext context = new
GroupMetadataManagerTestContext.Builder()
+ .withConsumerGroupAssignors(Collections.singletonList(assignor))
+ .withMetadataImage(new MetadataImageBuilder()
+ .addTopic(fooTopicId, fooTopicName, 2)
+ .build())
+ .withConsumerGroup(new ConsumerGroupBuilder(groupId, 10)
+ .withMember(new ConsumerGroupMember.Builder(memberId1)
+ .setState(MemberState.STABLE)
+ .setMemberEpoch(10)
+ .setPreviousMemberEpoch(10)
+ .setClientId(DEFAULT_CLIENT_ID)
+ .setClientHost(DEFAULT_CLIENT_ADDRESS.toString())
+ .setSubscribedTopicRegex("foo*")
+ .setServerAssignorName("range")
+ .setAssignedPartitions(mkAssignment(
+ mkTopicAssignment(fooTopicId, 0, 1)))
+ .build())
+ .withResolvedRegularExpression("foo*", new
ResolvedRegularExpression(
+ Collections.singleton(fooTopicName),
+ 100L,
+ 12345L))
+ .withAssignment(memberId1, mkAssignment(
+ mkTopicAssignment(fooTopicId, 0, 1)))
+ .withAssignmentEpoch(10))
+ .build();
+
+ CoordinatorResult<ConsumerGroupHeartbeatResponseData,
CoordinatorRecord> result = context.consumerGroupHeartbeat(
+ new ConsumerGroupHeartbeatRequestData()
+ .setGroupId(groupId)
+ .setMemberId(memberId2)
+ .setMemberEpoch(0)
+ .setRebalanceTimeoutMs(10000)
+ .setSubscribedTopicRegex("foo*")
+ .setTopicPartitions(Collections.emptyList()));
+
+ assertEquals(
+ new ConsumerGroupHeartbeatResponseData()
+ .setMemberId(memberId2)
+ .setMemberEpoch(11)
+ .setHeartbeatIntervalMs(5000)
+ .setAssignment(new
ConsumerGroupHeartbeatResponseData.Assignment()),
Review Comment:
Correct. The target assignor is computed but the new member cannot get the
newly assigned partitions yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
