lianetm commented on code in PR #17750:
URL: https://github.com/apache/kafka/pull/17750#discussion_r1838665601
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/TargetAssignmentBuilder.java:
##########
@@ -89,6 +92,144 @@ public Map<String, MemberAssignment> targetAssignment() {
}
}
+ public static class ConsumerTargetAssignmentBuilder extends
TargetAssignmentBuilder<ConsumerGroupMember, ConsumerTargetAssignmentBuilder> {
+
+ /**
+ * The resolved regular expressions.
+ */
+ private Map<String, ResolvedRegularExpression>
resolvedRegularExpressions = Collections.emptyMap();
+
+ public ConsumerTargetAssignmentBuilder(
+ String groupId,
+ int groupEpoch,
+ PartitionAssignor assignor
+ ) {
+ super(groupId, groupEpoch, assignor);
+ }
+
+ /**
+ * Adds all the existing resolved regular expressions.
+ *
+ * @param resolvedRegularExpressions The resolved regular expressions.
+ * @return This object.
+ */
+ public ConsumerTargetAssignmentBuilder withResolvedRegularExpressions(
+ Map<String, ResolvedRegularExpression> resolvedRegularExpressions
+ ) {
+ this.resolvedRegularExpressions = resolvedRegularExpressions;
+ return self();
+ }
+
+ @Override
+ protected ConsumerTargetAssignmentBuilder self() {
+ return this;
+ }
+
+ @Override
+ protected CoordinatorRecord newTargetAssignmentRecord(
+ String groupId,
+ String memberId,
+ Map<Uuid, Set<Integer>> partitions
+ ) {
+ return
GroupCoordinatorRecordHelpers.newConsumerGroupTargetAssignmentRecord(
+ groupId,
+ memberId,
+ partitions
+ );
+ }
+
+ @Override
+ protected CoordinatorRecord newTargetAssignmentEpochRecord(String
groupId, int assignmentEpoch) {
+ return
GroupCoordinatorRecordHelpers.newConsumerGroupTargetAssignmentEpochRecord(
+ groupId,
+ assignmentEpoch
+ );
+ }
+
+ @Override
+ protected MemberSubscriptionAndAssignmentImpl
newMemberSubscriptionAndAssignment(
+ ConsumerGroupMember member,
+ Assignment memberAssignment,
+ TopicIds.TopicResolver topicResolver
+ ) {
+ Set<String> subscriptions = member.subscribedTopicNames();
+
+ // Check whether the member is also subscribed to a regular
expression. If it is,
+ // create the union of the two subscriptions.
+ String subscribedTopicRegex = member.subscribedTopicRegex();
+ if (subscribedTopicRegex != null &&
!subscribedTopicRegex.isEmpty()) {
+ ResolvedRegularExpression resolvedRegularExpression =
resolvedRegularExpressions.get(subscribedTopicRegex);
+ if (resolvedRegularExpression != null) {
+ if (subscriptions.isEmpty()) {
+ subscriptions = resolvedRegularExpression.topics;
+ } else if (!resolvedRegularExpression.topics.isEmpty()) {
+ // We only use a UnionSet when the member uses both
type of subscriptions. The
+ // protocol allows it. However, the Apache Kafka
Consumer does not support it.
+ // Other clients such as librdkafka may support it.
Review Comment:
No, as far as I know. The java consumer does not allow mixed subscription
types today, so seems sensible to just keep that principle when introducing the
new regex subscription and that's the plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
