junrao commented on code in PR #17739:
URL: https://github.com/apache/kafka/pull/17739#discussion_r1841253380
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -1602,8 +1602,6 @@ protected void
updateFetchOffsetMetadata(Optional<LogOffsetMetadata> fetchOffset
protected Optional<LogOffsetMetadata> fetchOffsetMetadata() {
lock.readLock().lock();
try {
- if (findNextFetchOffset.get())
Review Comment:
Hmm, my understanding is that endOffset always points to the endOffset of
all cached batches in sharePartition. nextFetchOffset() doesn't update
endOffset. It only turns findNextFetchOffset off when the next fetch offset
reaches endOffset. It could take multiple nextFetchOffset() calls before
findNextFetchOffset is reset to off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
