adixitconfluent commented on code in PR #17739:
URL: https://github.com/apache/kafka/pull/17739#discussion_r1842159746
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -1602,8 +1602,6 @@ protected void
updateFetchOffsetMetadata(Optional<LogOffsetMetadata> fetchOffset
protected Optional<LogOffsetMetadata> fetchOffsetMetadata() {
lock.readLock().lock();
try {
- if (findNextFetchOffset.get())
Review Comment:
@apoorvmittal10:
>We want to keep fetchOffsetMetadata in SharePartition so when there is no
change to endOffset then existing fetchOffsetMetadata can be used to calculate
min bytes, correc?
Yes
>The current code solves mostly all but there could be an edge case where
only single message is released from between and the batch that holds that
released message might not be able to alone satisfy min bytes criteria, is that
something we are solving?
We are only solving common case where all fetched data is acquirable. So,
this case is something we're not solving right now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
