chia7712 commented on code in PR #17797:
URL: https://github.com/apache/kafka/pull/17797#discussion_r1841868061
##########
tests/kafkatest/tests/core/downgrade_test.py:
##########
@@ -81,6 +81,8 @@ def wait_until_rejoin(self):
timeout_sec=60, backoff_sec=1, err_msg="Replicas did not
rejoin the ISR in a reasonable amount of time")
@cluster(num_nodes=7)
+ @parametrize(version=str(LATEST_3_9), compression_types=["snappy"])
+ @parametrize(version=str(LATEST_3_9), compression_types=["zstd"],
security_protocol="SASL_SSL")
Review Comment:
Perhaps we should use `matrix` to include those test suites.
```
@matrix(version=[str(LATEST_2_5), str(LATEST_2_6), str(LATEST_2_7),
str(LATEST_2_8), str(LATEST_3_0),
str(LATEST_3_1), str(LATEST_3_2), str(LATEST_3_3),
str(LATEST_3_4), str(LATEST_3_5),
str(LATEST_3_6), str(LATEST_3_7), str(LATEST_3_8),
str(LATEST_3_9)],
compression_types=[["none"], ["zstd"], ["snappy"]],
security_protocols=["SASL_SSL", PLAINTEXT],
static_membership=[False, True]
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
