chia7712 commented on code in PR #17797:
URL: https://github.com/apache/kafka/pull/17797#discussion_r1841985903
##########
tests/kafkatest/tests/core/downgrade_test.py:
##########
@@ -81,6 +81,8 @@ def wait_until_rejoin(self):
timeout_sec=60, backoff_sec=1, err_msg="Replicas did not
rejoin the ISR in a reasonable amount of time")
@cluster(num_nodes=7)
+ @parametrize(version=str(LATEST_3_9), compression_types=["snappy"])
+ @parametrize(version=str(LATEST_3_9), compression_types=["zstd"],
security_protocol="SASL_SSL")
Review Comment:
> This is three times more tests per version. I am wondering, if the intend
of the old parametrization was to NOT run so many tests.
Maybe we can remove snappy? or using the origin style is fine to me :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
