CalvinConfluent commented on code in PR #17822:
URL: https://github.com/apache/kafka/pull/17822#discussion_r1844300551
##########
core/src/test/scala/integration/kafka/api/TransactionsExpirationTest.scala:
##########
@@ -81,9 +81,14 @@ class TransactionsExpirationTest extends
KafkaServerTestHarness {
super.tearDown()
}
- @ParameterizedTest(name =
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
- @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll"))
- def testBumpTransactionalEpochAfterInvalidProducerIdMapping(quorum: String,
groupProtocol: String): Unit = {
+ @ParameterizedTest
Review Comment:
I think you need to use `@ParameterizedTest(name =
"{displayName}.quorum={0}.groupProtocol={1}.isTV2Enabled={2}")`. Can you help
verify?
##########
core/src/test/scala/integration/kafka/api/TransactionsExpirationTest.scala:
##########
@@ -81,9 +81,14 @@ class TransactionsExpirationTest extends
KafkaServerTestHarness {
super.tearDown()
}
- @ParameterizedTest(name =
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
- @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll"))
- def testBumpTransactionalEpochAfterInvalidProducerIdMapping(quorum: String,
groupProtocol: String): Unit = {
+ @ParameterizedTest
Review Comment:
ummm, actually it works. interesting. Why would we even use the above
formating in other tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
