m1a2st commented on code in PR #17440:
URL: https://github.com/apache/kafka/pull/17440#discussion_r1850159400
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java:
##########
@@ -186,9 +187,15 @@ public NetworkClientDelegate.PollResult poll(final long
currentTimeMs) {
*/
public CompletableFuture<Map<TopicPartition, OffsetAndTimestampInternal>>
fetchOffsets(
Map<TopicPartition, Long> timestampsToSearch,
- boolean requireTimestamps) {
+ boolean requireTimestamps,
+ List<CompletableFuture<RuntimeException>> metadataErrors
+ ) {
+ AtomicReference<CompletableFuture<Map<TopicPartition,
OffsetAndTimestampInternal>>>
+ topicToOffsetsResult = new AtomicReference<>();
Review Comment:
I originally wrapped it in an additional layer to avoid the issue with Java
lambdas requiring immutable variables. However, I’ve refactored this
implementation to avoid any misunderstandings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
