m1a2st commented on code in PR #17440:
URL: https://github.com/apache/kafka/pull/17440#discussion_r1850170638
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java:
##########
@@ -150,6 +152,8 @@ private void maybePropagateMetadataError() {
try {
metadata.maybeThrowAnyException();
} catch (Exception e) {
+ metadataException.completeExceptionally(e);
+ metadataException = metadataException.newIncompleteFuture();
Review Comment:
I don’t see any real benefit; I simply chose to use this method because Java
provides it. Ultimately, this method internally just creates a new
CompletedFuture.
```java
public <U> CompletableFuture<U> newIncompleteFuture() {
return new CompletableFuture<U>();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
