kirktrue commented on code in PR #17440:
URL: https://github.com/apache/kafka/pull/17440#discussion_r1868631701
##########
core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala:
##########
@@ -576,8 +576,9 @@ object QuorumTestHarness {
// The following parameter groups are to *temporarily* avoid bugs with the
CONSUMER group protocol Consumer
// implementation that would otherwise cause tests to fail.
def
getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_KAFKA_16176:
stream.Stream[Arguments] =
getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly
- def
getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_KAFKA_17696:
stream.Stream[Arguments] =
getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly
def
getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_KAFKA_17960:
stream.Stream[Arguments] =
getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly
def
getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_KAFKA_17961:
stream.Stream[Arguments] =
getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly
def
getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_KAFKA_17964:
stream.Stream[Arguments] =
getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly
+ def
getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_KAFKA_18034:
stream.Stream[Arguments] =
getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly
+ def
getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_KAFKA_18095:
stream.Stream[Arguments] =
getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly
Review Comment:
KAFKA-18095 is marked as resolved in Jira. I'm assuming that means if you
rebase, update the tests that use
`getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_KAFKA_18095`
to `getTestQuorumAndGroupProtocolParametersAll`, and retest, those tests should
pass, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
