lianetm commented on code in PR #17440:
URL: https://github.com/apache/kafka/pull/17440#discussion_r1871585961
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java:
##########
@@ -150,7 +155,11 @@ private void maybePropagateMetadataError() {
try {
metadata.maybeThrowAnyException();
Review Comment:
do we need to clear the metadata error right after this line? if we make it
here , it means that the `metadataError` recovered (ex. unknown/unauth topic
not in the subscription anymore), so we shouldn't be keeping/propagating any
previous error I would say. Makes sense?
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -325,4 +333,21 @@ void cleanup() {
log.debug("Closed the consumer network thread");
}
}
+
+ /**
+ * If there is a metadata error, completed all uncompleted events with the
metadata error.
Review Comment:
```suggestion
* If there is a metadata error, complete all uncompleted events that
require subscription metadata
```
something like it, to clarify that it's only for the ones requiring metadata
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
