dajac commented on code in PR #17976:
URL: https://github.com/apache/kafka/pull/17976#discussion_r1869079213
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/consumer/ConsumerGroup.java:
##########
@@ -655,24 +722,28 @@ public void createGroupTombstoneRecordsWithReplacedMember(
String leavingMemberId,
String joiningMemberId
) {
- members().forEach((memberId, __) -> {
+ members.keySet().forEach(memberId -> {
String removedMemberId = memberId.equals(leavingMemberId) ?
joiningMemberId : memberId;
-
records.add(GroupCoordinatorRecordHelpers.newConsumerGroupCurrentAssignmentTombstoneRecord(groupId(),
removedMemberId));
+
records.add(GroupCoordinatorRecordHelpers.newConsumerGroupCurrentAssignmentTombstoneRecord(groupId,
removedMemberId));
});
- members().forEach((memberId, __) -> {
+ members.keySet().forEach(memberId -> {
String removedMemberId = memberId.equals(leavingMemberId) ?
joiningMemberId : memberId;
-
records.add(GroupCoordinatorRecordHelpers.newConsumerGroupTargetAssignmentTombstoneRecord(groupId(),
removedMemberId));
+
records.add(GroupCoordinatorRecordHelpers.newConsumerGroupTargetAssignmentTombstoneRecord(groupId,
removedMemberId));
});
-
records.add(GroupCoordinatorRecordHelpers.newConsumerGroupTargetAssignmentEpochTombstoneRecord(groupId()));
+
records.add(GroupCoordinatorRecordHelpers.newConsumerGroupTargetAssignmentEpochTombstoneRecord(groupId));
- members().forEach((memberId, __) -> {
+ members.keySet().forEach(memberId -> {
String removedMemberId = memberId.equals(leavingMemberId) ?
joiningMemberId : memberId;
-
records.add(GroupCoordinatorRecordHelpers.newConsumerGroupMemberSubscriptionTombstoneRecord(groupId(),
removedMemberId));
+
records.add(GroupCoordinatorRecordHelpers.newConsumerGroupMemberSubscriptionTombstoneRecord(groupId,
removedMemberId));
});
-
records.add(GroupCoordinatorRecordHelpers.newConsumerGroupSubscriptionMetadataTombstoneRecord(groupId()));
-
records.add(GroupCoordinatorRecordHelpers.newConsumerGroupEpochTombstoneRecord(groupId()));
+ resolvedRegularExpressions.keySet().forEach(regex ->
+
records.add(GroupCoordinatorRecordHelpers.newConsumerGroupRegularExpressionTombstone(groupId,
regex))
+ );
+
+
records.add(GroupCoordinatorRecordHelpers.newConsumerGroupSubscriptionMetadataTombstoneRecord(groupId));
+
records.add(GroupCoordinatorRecordHelpers.newConsumerGroupEpochTombstoneRecord(groupId));
Review Comment:
we still follow the convention when we generate them but the ordering does
not matter on replay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
