dajac commented on code in PR #17976:
URL: https://github.com/apache/kafka/pull/17976#discussion_r1869083798


##########
core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala:
##########
@@ -660,6 +660,24 @@ class GroupCoordinatorBaseRequestTest(cluster: 
ClusterInstance) {
     )
   }
 
+  protected def classicLeaveGroup(

Review Comment:
   `leaveGroupWithOldProtocol` assumes that the memberid sent must be the one 
received. when the admin api is used to remove a static member, the memberid is 
not set but the correct one is returned. this is why i put a raw method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to