kevin-wu24 commented on code in PR #17500:
URL: https://github.com/apache/kafka/pull/17500#discussion_r1870321728
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -3426,6 +3426,12 @@ public Optional<SnapshotWriter<T>> createSnapshot(
throw new IllegalStateException("Cannot create snapshot before the
replica has been initialized");
}
+ long baseOffset = log.read(snapshotId.offset(),
Isolation.COMMITTED).startOffsetMetadata.offset();
Review Comment:
Looking at this again, it makes more sense to have this moved to the
`ReplicatedLog` level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
