kevin-wu24 commented on PR #17500: URL: https://github.com/apache/kafka/pull/17500#issuecomment-2520953261
> Thanks for the changes @kevin-wu24 . Looks good in general. Here are some comments. Thanks for the review @jsancio. Pushed a commit: * Now, we make the log read at the `ReplicatedLog` level, after we perform other checks in `createNewSnapshot`. * Added/modified tests in `KafkaMetadataLogTest` and `MockLogTest`. * Addressed `KafkaRaftClientSnapshotTest` comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
