splett2 commented on code in PR #18045:
URL: https://github.com/apache/kafka/pull/18045#discussion_r1870330236
##########
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##########
@@ -350,12 +350,6 @@ public ControllerResult<BrokerRegistrationReply>
registerBroker(
Uuid prevIncarnationId = null;
if (existing != null) {
prevIncarnationId = existing.incarnationId();
- if (heartbeatManager.hasValidSession(brokerId, existing.epoch())) {
- if (!request.incarnationId().equals(prevIncarnationId)) {
- throw new DuplicateBrokerRegistrationException("Another
broker is " +
- "registered with that broker id.");
- }
- }
Review Comment:
we fence broker registrations for the same ID while the session is active,
this ensures that a broker goes through the fenced -> re-registered transition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
