cmccabe commented on code in PR #18045:
URL: https://github.com/apache/kafka/pull/18045#discussion_r1870371478
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -1422,11 +1422,17 @@ void handleBrokerInControlledShutdown(int brokerId,
long brokerEpoch, List<ApiMe
* @param records The record list to append to.
*/
void handleBrokerUncleanShutdown(int brokerId, List<ApiMessageAndVersion>
records) {
- if (!featureControl.metadataVersion().isElrSupported()) return;
- generateLeaderAndIsrUpdates("handleBrokerUncleanShutdown", NO_LEADER,
NO_LEADER, brokerId, records,
- brokersToIsrs.partitionsWithBrokerInIsr(brokerId));
- generateLeaderAndIsrUpdates("handleBrokerUncleanShutdown", NO_LEADER,
NO_LEADER, brokerId, records,
- brokersToElrs.partitionsWithBrokerInElr(brokerId));
+ if (!featureControl.metadataVersion().isElrSupported()) {
Review Comment:
This is a nit, but it would be nice to remove the ! here and just put the
ELR case first. Since we now have both cases handled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
