adixitconfluent commented on code in PR #18053:
URL: https://github.com/apache/kafka/pull/18053#discussion_r1871701025
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -1142,34 +1176,29 @@ private boolean stateNotActive() {
return partitionState() != SharePartitionState.ACTIVE;
}
- private void completeInitializationWithException(CompletableFuture<Void>
future, Throwable exception) {
+ private void completeInitializationWithException() {
lock.writeLock().lock();
try {
partitionState = SharePartitionState.FAILED;
} finally {
lock.writeLock().unlock();
}
- future.completeExceptionally(exception);
}
- private void maybeCompleteInitialization(CompletableFuture<Void> future) {
+ private InitializationResult maybeCompleteInitialization() {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
