AndrewJSchofield commented on code in PR #18053:
URL: https://github.com/apache/kafka/pull/18053#discussion_r1871561639
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -380,6 +381,7 @@ public CompletableFuture<Void> maybeInitialize() {
// All the pending requests should wait to get completed before the
share partition is initialized.
// Attain lock to avoid any concurrent requests to be processed.
lock.writeLock().lock();
+ AtomicReference<Optional<Throwable>> futureException = new
AtomicReference<>(Optional.empty());
Review Comment:
I'm perfectly happy with your reasoning. I will just push on this kind of
thing to make sure you meant it. Leave it as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
