cadonna commented on code in PR #18066:
URL: https://github.com/apache/kafka/pull/18066#discussion_r1875628074


##########
README.md:
##########
@@ -1,5 +1,14 @@
-Apache Kafka
-=================
+# Apache Kafka
+
+<a href="https://kafka.apache.org/";>
+<picture>
+  <source media="(prefers-color-scheme: dark)" 
srcset="docs/images/kafka-logo-readme-dark.svg">
+  <source media="(prefers-color-scheme: light)" 
srcset="docs/images/kafka-logo-readme-light.svg">
+  <img alt="Kafka Logo" src="docs/images/kafka-logo-readme-light.svg" 
width="80"> 
+</picture>
+</a>
+<br><br>

Review Comment:
   Could you give examples where the logo is used this way? 
   I quickly looked into some but could not find the logo used in this way. 
   I think integrating the logo into the title like 
[Paimon](https://github.com/apache/paimon) does it, would be the best solution.
   
   I would remove the `About Apache Kafka` title, but keep the paragraph.
   
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to