cadonna commented on code in PR #18066: URL: https://github.com/apache/kafka/pull/18066#discussion_r1876238774
########## README.md: ########## @@ -1,5 +1,14 @@ -Apache Kafka -================= +# Apache Kafka + +<a href="https://kafka.apache.org/";> +<picture> + <source media="(prefers-color-scheme: dark)" srcset="docs/images/kafka-logo-readme-dark.svg"> + <source media="(prefers-color-scheme: light)" srcset="docs/images/kafka-logo-readme-light.svg"> + <img alt="Kafka Logo" src="docs/images/kafka-logo-readme-light.svg" width="80"> +</picture> +</a> +<br><br> Review Comment: @swikarpat > And this is standard way other repo on GitHub uses Why can you not provide some examples? I provided an example for a solution I find good. Actually, it does not really matter if other projects on GitHub and/or other Apache projects put the logo in the README that way. What matters is that we agree whether to put a logo in the README and where to put it. > section is useful as it gives starting point for viewers. Probably, there is a misunderstanding. I just requested to remove the `About Apache Kafka` TITLE, I am fine with the sentence "Apache Kafka is an open-source distributed event streaming ..." under the title. There is an additional issue here that the title `About Apache Kafka` (on level `##`) is a level above section `Prerequisite` (on level `###`) and all other sections below. So, all sections seem to be under `About Apache Kafka` which does not seem correct. Regarding the tone of your comment, it seems your are upset. I am sorry for that. However, this is not how we work in the Apache Kafka project. We try to agree on changes and then we merge them. Here we haven't found agreement yet. Agreement means accepting feedback and backing one's opinions with arguments. I will not approve and merge this PR as it is for the reasons stated above. ########## README.md: ########## @@ -1,5 +1,14 @@ -Apache Kafka -================= +# Apache Kafka + +<a href="https://kafka.apache.org/";> +<picture> + <source media="(prefers-color-scheme: dark)" srcset="docs/images/kafka-logo-readme-dark.svg"> + <source media="(prefers-color-scheme: light)" srcset="docs/images/kafka-logo-readme-light.svg"> + <img alt="Kafka Logo" src="docs/images/kafka-logo-readme-light.svg" width="80"> +</picture> +</a> +<br><br> Review Comment: @swikarpat > And this is standard way other repo on GitHub uses Why can you not provide some examples? I provided an example for a solution I find good. Actually, it does not really matter if other projects on GitHub and/or other Apache projects put the logo in the README that way. What matters is that we agree whether to put a logo in the README and where to put it. > section is useful as it gives starting point for viewers. Probably, there is a misunderstanding. I just requested to remove the `About Apache Kafka` TITLE, I am fine with the sentence "Apache Kafka is an open-source distributed event streaming ..." under the title. There is an additional issue here that the title `About Apache Kafka` (on level `##`) is a level above section `Prerequisite` (on level `###`) and all other sections below. So, all sections seem to be under `About Apache Kafka` which does not seem correct. Regarding the tone of your comment, it seems your are upset. I am sorry for that. However, this is not how we work in the Apache Kafka project. We try to agree on changes and then we merge them. Here we haven't found agreement yet. Agreement means accepting feedback and backing one's opinions with arguments. I will not approve and merge this PR as it is for the reasons stated above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
