guozhangwang commented on code in PR #18150:
URL: https://github.com/apache/kafka/pull/18150#discussion_r1883012562
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/TableSuppressNode.java:
##########
@@ -16,12 +16,10 @@
*/
package org.apache.kafka.streams.kstream.internals.graph;
-import org.apache.kafka.streams.processor.internals.StoreFactory;
-
public class TableSuppressNode<K, V> extends StatefulProcessorNode<K, V> {
public TableSuppressNode(final String nodeName,
final ProcessorParameters<K, V, ?, ?>
processorParameters,
- final StoreFactory
materializedKTableStoreBuilder) {
- super(nodeName, processorParameters, materializedKTableStoreBuilder);
+ final String[] storeNames) {
Review Comment:
The `storeNames` are not needed?
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java:
##########
@@ -589,10 +582,16 @@ public KTable<K, V> suppress(final Suppressed<? super K>
suppressed) {
.withLoggingDisabled();
}
+ final ProcessorSupplier<K, Change<V>, K, Change<V>>
suppressionSupplier = new KTableSuppressProcessorSupplier<>(
+ suppressedInternal,
+ storeBuilder,
+ this
+ );
+
final ProcessorGraphNode<K, Change<V>> node = new TableSuppressNode<>(
name,
new ProcessorParameters<>(suppressionSupplier, name),
- StoreBuilderWrapper.wrapStoreBuilder(storeBuilder)
+ new String[]{storeName}
Review Comment:
Is this intentional? The callee seems not using the `storeName` below:
https://github.com/apache/kafka/pull/18150/files#diff-c1133b80fb36ee7e4fbf7a26007f63e41a411e7f36e45aa96373afd9ebdc5559R22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
