ableegoldman commented on code in PR #18150:
URL: https://github.com/apache/kafka/pull/18150#discussion_r1885483095
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java:
##########
@@ -589,10 +582,16 @@ public KTable<K, V> suppress(final Suppressed<? super K>
suppressed) {
.withLoggingDisabled();
}
+ final ProcessorSupplier<K, Change<V>, K, Change<V>>
suppressionSupplier = new KTableSuppressProcessorSupplier<>(
+ suppressedInternal,
+ storeBuilder,
+ this
+ );
+
final ProcessorGraphNode<K, Change<V>> node = new TableSuppressNode<>(
name,
new ProcessorParameters<>(suppressionSupplier, name),
- StoreBuilderWrapper.wrapStoreBuilder(storeBuilder)
+ new String[]{storeName}
Review Comment:
it's definitely not being used in the PR, but actually we do still need it
so it should/will be used (see
https://github.com/apache/kafka/pull/18150/files#r1885482579)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
