m1a2st commented on PR #18050: URL: https://github.com/apache/kafka/pull/18050#issuecomment-2543124548
Thanks for @kirktrue comments, > I have a personal preference to avoid different RequestManager classes from calling one another directly. I could imagine introducing a class that's created in the RequestManagers class and then passed down into any RequestManager that needs it. Both `AbstractHeartbeatRequestManager` and `CommitRequestManager` now require `CoordinatorRequestManager`, so I’m uncertain whether creating a `Tracker` class would effectively prevent different `RequestManager` classes from directly invoking one another. Additionally, fatal errors include not only `GROUP_AUTHORIZATION` but also other unpredictable exceptions. If we introduce a new class, it would essentially serve as a record. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
