lianetm commented on PR #18050: URL: https://github.com/apache/kafka/pull/18050#issuecomment-2546167787
Regarding the concern with the interaction between the request managers, I totally see how in some cases a 3rd component can help decouple, but that becomes more interesting when we have 2-way interactions, mostly because it also introduces state to maintain and another player in the architecture, so better not to pay that price if not really needed? The interaction here seems fairly simple to me (1 way only): `coordinatorMgr` exposes coordinator node and fatal error to others (so HB/Commit mgr use it). Also, the dependency already exists before this PR, to access the coordinator node, we're just extending it to access fatal errors. Those are my first thoughts on that, but of course, happy to hear more about the tracker idea if we think it's a fair trade-off here and I'm not seeing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
