chia7712 commented on code in PR #18352:
URL: https://github.com/apache/kafka/pull/18352#discussion_r1899593567
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -173,14 +173,14 @@ class KafkaApisTest extends Logging {
overrideProperties: Map[String, String] = Map.empty,
featureVersions: Seq[FeatureVersion] = Seq.empty):
KafkaApis = {
val properties = if (raftSupport) {
Review Comment:
Could you please remove `raftSupport` as well?
##########
core/src/test/scala/integration/kafka/api/CustomQuotaCallbackTest.scala:
##########
@@ -179,7 +183,26 @@ class CustomQuotaCallbackTest extends
IntegrationTestHarness with SaslSetup {
private def createTopic(topic: String, numPartitions: Int, leader: Int):
Unit = {
val assignment = (0 until numPartitions).map { i => i -> Seq(leader)
}.toMap
- TestUtils.createTopic(null, topic, assignment, servers)
+ val adminZkClient = new AdminZkClient(null)
Review Comment:
this test is disabled, so we can just comment the code
`TestUtils.createTopic(null, topic, assignment, servers)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
