chia7712 commented on code in PR #18352:
URL: https://github.com/apache/kafka/pull/18352#discussion_r1899702437
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -614,136 +288,12 @@ class KafkaApisTest extends Logging {
assertEquals(cgConfigs.size, configs.size)
}
- @Test
- def testAlterConfigsClientMetrics(): Unit = {
Review Comment:
why to remove this test case? Does this scenario belong to zk only?
##########
core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala:
##########
@@ -95,9 +95,40 @@ class DynamicBrokerConfigTest {
}
}
+ @Test
+ def testEnableDefaultUncleanLeaderElection(): Unit = {
Review Comment:
we did not have such test case before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
