dajac commented on code in PR #18396:
URL: https://github.com/apache/kafka/pull/18396#discussion_r1904147998
##########
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorRecordHelpers.java:
##########
@@ -46,7 +47,7 @@ public static CoordinatorRecord newShareSnapshotRecord(String
groupId, Uuid topi
.setDeliveryCount(batch.deliveryCount())
.setDeliveryState(batch.deliveryState()))
.collect(Collectors.toList())),
- ShareCoordinator.SHARE_SNAPSHOT_RECORD_VALUE_VERSION)
+ (short) 0)
Review Comment:
It is better to hardcode the version here in order to avoid using the wrong
ones as it was the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
