AndrewJSchofield commented on code in PR #18396:
URL: https://github.com/apache/kafka/pull/18396#discussion_r1905846691
##########
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinator.java:
##########
@@ -32,11 +32,6 @@
import java.util.function.IntSupplier;
public interface ShareCoordinator {
- short SHARE_SNAPSHOT_RECORD_KEY_VERSION = 0;
- short SHARE_SNAPSHOT_RECORD_VALUE_VERSION = 0;
- short SHARE_UPDATE_RECORD_KEY_VERSION = 1;
- short SHARE_UPDATE_RECORD_VALUE_VERSION = 1;
Review Comment:
We don't support migration of the share-group state topic data from 4.0 to
4.1, so not strictly necessary. But really, it is not ideal. Probably should
fix it. I'll open an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
