brandboat commented on code in PR #18448:
URL: https://github.com/apache/kafka/pull/18448#discussion_r1908949000
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -854,7 +856,7 @@ synchronized TxnRequestHandler nextRequest(boolean
hasIncompleteBatches) {
return null;
}
- if (nextRequestHandler.isEndTxn() && (!isTransactionV2Enabled() &&
!transactionStarted)) {
+ if (nextRequestHandler.isEndTxn() && !transactionStarted) {
Review Comment:
Pardon me, could you give me some hint? Did you mean we need to modify the
log in line 862
```java
log.debug("Not sending EndTxn for completed transaction
since no partitions " +
"or offsets were successfully added");
```
to something else when using TV2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
