jolshan commented on code in PR #18448:
URL: https://github.com/apache/kafka/pull/18448#discussion_r1909223029
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -854,7 +856,7 @@ synchronized TxnRequestHandler nextRequest(boolean
hasIncompleteBatches) {
return null;
}
- if (nextRequestHandler.isEndTxn() && (!isTransactionV2Enabled() &&
!transactionStarted)) {
+ if (nextRequestHandler.isEndTxn() && !transactionStarted) {
Review Comment:
Right -- the implication of successfully added is a little confusing in the
TV2 case because it is not a matter of "successfully" adding but a matter of
not attempting to add any at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
