ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1909866317
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorRecordHelpers.java:
##########
@@ -552,18 +551,14 @@ public static CoordinatorRecord
newEmptyGroupMetadataRecord(
* @param topic The topic name.
* @param partitionId The partition id.
* @param offsetAndMetadata The offset and metadata.
- * @param metadataVersion The metadata version.
* @return The record.
*/
public static CoordinatorRecord newOffsetCommitRecord(
String groupId,
String topic,
int partitionId,
- OffsetAndMetadata offsetAndMetadata,
- MetadataVersion metadataVersion
+ OffsetAndMetadata offsetAndMetadata
) {
- short version =
metadataVersion.offsetCommitValueVersion(offsetAndMetadata.expireTimestampMs.isPresent());
Review Comment:
Fixed - still working through a few other things.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorRecordHelpers.java:
##########
@@ -552,18 +551,14 @@ public static CoordinatorRecord
newEmptyGroupMetadataRecord(
* @param topic The topic name.
* @param partitionId The partition id.
* @param offsetAndMetadata The offset and metadata.
- * @param metadataVersion The metadata version.
* @return The record.
*/
public static CoordinatorRecord newOffsetCommitRecord(
String groupId,
String topic,
int partitionId,
- OffsetAndMetadata offsetAndMetadata,
- MetadataVersion metadataVersion
+ OffsetAndMetadata offsetAndMetadata
) {
- short version =
metadataVersion.offsetCommitValueVersion(offsetAndMetadata.expireTimestampMs.isPresent());
Review Comment:
Fixed this one - still working through a few other things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
