ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1909975001
##########
clients/src/test/java/org/apache/kafka/common/requests/OffsetsForLeaderEpochRequestTest.java:
##########
@@ -40,20 +40,4 @@ public void testForConsumerRequiresVersion3() {
assertEquals(OffsetsForLeaderEpochRequest.CONSUMER_REPLICA_ID,
request.replicaId());
}
}
-
- @Test
- public void testDefaultReplicaId() {
- for (short version : ApiKeys.OFFSET_FOR_LEADER_EPOCH.allVersions()) {
- int replicaId = 1;
- OffsetsForLeaderEpochRequest.Builder builder =
OffsetsForLeaderEpochRequest.Builder.forFollower(
- version, new OffsetForLeaderTopicCollection(), replicaId);
- OffsetsForLeaderEpochRequest request = builder.build();
- OffsetsForLeaderEpochRequest parsed =
OffsetsForLeaderEpochRequest.parse(request.serialize(), version);
- if (version < 3)
-
assertEquals(OffsetsForLeaderEpochRequest.DEBUGGING_REPLICA_ID,
parsed.replicaId());
- else
- assertEquals(replicaId, parsed.replicaId());
Review Comment:
The value of this test is a bit low, but I added it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
