clolov commented on code in PR #18505:
URL: https://github.com/apache/kafka/pull/18505#discussion_r1913071846
##########
core/src/main/scala/kafka/tools/DumpLogSegments.scala:
##########
@@ -548,7 +548,7 @@ object DumpLogSegments {
}
val json = new ObjectNode(JsonNodeFactory.instance)
- json.set("type", new TextNode(version.toString))
+ json.set("version", new TextNode(version.toString))
Review Comment:
For my understanding, if `type` is changed to `version` here shouldn't it
also be changed to `version` in `prepareKey` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
