dajac commented on code in PR #18505:
URL: https://github.com/apache/kafka/pull/18505#discussion_r1913210424
##########
core/src/main/scala/kafka/tools/DumpLogSegments.scala:
##########
@@ -548,7 +548,7 @@ object DumpLogSegments {
}
val json = new ObjectNode(JsonNodeFactory.instance)
- json.set("type", new TextNode(version.toString))
+ json.set("version", new TextNode(version.toString))
Review Comment:
No, it should not. In the key, we get the type of the record together with
the serialized key. In the value, we have the version of the record together
with the serialized record. The format is defined here:
https://github.com/apache/kafka/blob/trunk/coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRecordSerde.java#L29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
