ahuang98 commented on code in PR #18387:
URL: https://github.com/apache/kafka/pull/18387#discussion_r1913714254
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -559,7 +559,16 @@ class KafkaConfig private(doLog: Boolean, val props:
util.Map[_, _])
controllerListenerNames.flatMap { name =>
controllerAdvertisedListeners
.find(endpoint =>
endpoint.listenerName.equals(ListenerName.normalised(name)))
- .orElse(controllerListenersValue.find(endpoint =>
endpoint.listenerName.equals(ListenerName.normalised(name))))
+ .orElse(
+ // implicit advertised controller listener
Review Comment:
nit: how do you feel about making the comment more verbose to explain why
this conversion is needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
