FrankYang0529 commented on code in PR #18387:
URL: https://github.com/apache/kafka/pull/18387#discussion_r1919474587
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -559,7 +559,16 @@ class KafkaConfig private(doLog: Boolean, val props:
util.Map[_, _])
controllerListenerNames.flatMap { name =>
controllerAdvertisedListeners
.find(endpoint =>
endpoint.listenerName.equals(ListenerName.normalised(name)))
- .orElse(controllerListenersValue.find(endpoint =>
endpoint.listenerName.equals(ListenerName.normalised(name))))
+ .orElse(
+ // implicit advertised controller listener
Review Comment:
> would it have made sense to remove the condition that
effectiveAdvertisedControllerListeners cannot be 0.0.0.0
Hi @ahuang98, thanks for the review. From the
[document](https://kafka.apache.org/documentation/#brokerconfigs_advertised.listeners),
it says `advertised.listeners` can't have `0.0.0.0` host name. I think we
still need to keep the check to avoid users define `advertised.listeners` with
`0.0.0.0` explicitly.
> have withWildcardHostnamesResolved account for the 0.0.0.0 case?
My change here to remove `0.0.0.0` from implicit advertised controller
listeners make `withWildcardHostnamesResolved` work for them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
