ijuma commented on code in PR #18621:
URL: https://github.com/apache/kafka/pull/18621#discussion_r1925445020
##########
docs/zk2kraft.html:
##########
@@ -176,5 +176,14 @@ <h5 class="anchor-heading">Removal metrics</h5>
Kafka remove all zookeeper dependencies, so the metrics is
removed.
</p>
</li>
+ <li>
+ <p>
+ Remove the metrics which is monitoring the leader election.
Review Comment:
This seems misleading - I think these metrics are related to the purgatory
for the ElectLeader operation - we still have metrics for monitoring leader
election.
##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -1635,24 +1635,6 @@ class Partition(val topicPartition: TopicPartition,
localLog.fetchOffsetSnapshot
}
- def legacyFetchOffsetsForTimestamp(timestamp: Long,
- maxNumOffsets: Int,
- isFromConsumer: Boolean,
- fetchOnlyFromLeader: Boolean): Seq[Long]
= inReadLock(leaderIsrUpdateLock) {
- val localLog = localLogWithEpochOrThrow(Optional.empty(),
fetchOnlyFromLeader)
- val allOffsets = localLog.legacyFetchOffsetsBefore(timestamp,
maxNumOffsets)
Review Comment:
Perhaps it can be removed from `LocalLog` too (in a follow-up).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
