clolov commented on code in PR #18621:
URL: https://github.com/apache/kafka/pull/18621#discussion_r1926865087
##########
core/src/main/java/kafka/server/builders/ReplicaManagerBuilder.java:
##########
@@ -130,36 +128,11 @@ public ReplicaManagerBuilder
setBrokerTopicStats(BrokerTopicStats brokerTopicSta
return this;
}
- public ReplicaManagerBuilder setIsShuttingDown(AtomicBoolean
isShuttingDown) {
- this.isShuttingDown = isShuttingDown;
- return this;
- }
-
- public ReplicaManagerBuilder
setDelayedProducePurgatory(DelayedOperationPurgatory<DelayedProduce>
delayedProducePurgatory) {
- this.delayedProducePurgatory = Optional.of(delayedProducePurgatory);
- return this;
- }
-
public ReplicaManagerBuilder
setDelayedFetchPurgatory(DelayedOperationPurgatory<DelayedFetch>
delayedFetchPurgatory) {
this.delayedFetchPurgatory = Optional.of(delayedFetchPurgatory);
return this;
}
- public ReplicaManagerBuilder
setDelayedRemoteFetchPurgatory(DelayedOperationPurgatory<DelayedRemoteFetch>
delayedRemoteFetchPurgatory) {
- this.delayedRemoteFetchPurgatory =
Optional.of(delayedRemoteFetchPurgatory);
- return this;
- }
-
- public ReplicaManagerBuilder
setDelayedDeleteRecordsPurgatory(DelayedOperationPurgatory<DelayedDeleteRecords>
delayedDeleteRecordsPurgatory) {
Review Comment:
Is there a reason why you can't remove the field(s) associated with this
setter (and others) as well? As far as I can see it is only used as an argument
for creating a ReplicaManager and you could just leave the instantiation of the
purgatory in the constructor of ReplicaManager. I am happy for this to be done
in a follow-up as long as it has already been accounted for and it isn't just a
miss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
