jsancio commented on code in PR #18304:
URL: https://github.com/apache/kafka/pull/18304#discussion_r1902195918
##########
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##########
@@ -3842,6 +3842,7 @@ public void testMetrics(boolean withKip853Rpc) throws
Exception {
assertNotNull(getMetric(context.metrics, "election-latency-max"));
assertNotNull(getMetric(context.metrics, "fetch-records-rate"));
assertNotNull(getMetric(context.metrics, "append-records-rate"));
+ assertNotNull(getMetric(context.metrics, "number-of-voters"));
Review Comment:
We should add a test for the leader specific metric the replica transition
from leader to follower to leader. We need to check that after those
transitions the metrics are reporting the correct value and not the previous
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
