kevin-wu24 commented on code in PR #18304:
URL: https://github.com/apache/kafka/pull/18304#discussion_r1926104916
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -649,6 +655,7 @@ private void onBecomeLeader(long currentTimeMs) {
resetConnections();
kafkaRaftMetrics.maybeUpdateElectionLatency(currentTimeMs);
+ kafkaRaftMetrics.addLeaderMetrics();
Review Comment:
I didn't consider that. I agree it is better to remove the leader specific
metrics in `LeaderState.close()` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
