ableegoldman commented on code in PR #17614:
URL: https://github.com/apache/kafka/pull/17614#discussion_r1942370387
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1236,10 +1237,11 @@ public void enforceRebalance(String reason) {
@Override
public void close() {
- close(Duration.ofMillis(DEFAULT_CLOSE_TIMEOUT_MS));
+
close(CloseOption.timeout(Duration.ofMillis(DEFAULT_CLOSE_TIMEOUT_MS)));
}
@Override
+ @SuppressWarnings("deprecation")
public void close(Duration timeout) {
Review Comment:
just echoing the above, we don't need to do anything at all in this method
besides call `close(CloseOptions.timeout(timeout));`
Note that this other stuff with the `acquire`/`release` will happen inside
the `close(CloseOptions option)` method so we're essentially doing this twice
for no reason as it is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
