ableegoldman commented on code in PR #17614:
URL: https://github.com/apache/kafka/pull/17614#discussion_r1945514843
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##########
@@ -1187,6 +1183,21 @@ public synchronized RequestFuture<Void>
maybeLeaveGroup(String leaveReason) {
return future;
}
+ private boolean
shouldSendLeaveGroupRequest(CloseOptions.GroupMembershipOperation
membershipOperation) {
+ if (CloseOptions.GroupMembershipOperation.REMAIN_IN_GROUP ==
membershipOperation) {
+ return false;
+ } else if (CloseOptions.GroupMembershipOperation.LEAVE_GROUP ==
membershipOperation) {
+ // According to KIP-1092, static members can leave the group if
the consumer group membership operation is LEAVE_GROUP.
+ return true;
Review Comment:
Ok 🙂 Unless others have concerns, I'm fine leaving as is -- just wanted to
think through what this would look like in practice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
