jsancio commented on code in PR #18387:
URL: https://github.com/apache/kafka/pull/18387#discussion_r1945545749
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -575,7 +585,8 @@ class KafkaConfig private(doLog: Boolean, val props:
util.Map[_, _])
if (advertisedListenersProp != null) {
CoreUtils.listenerListToEndPoints(advertisedListenersProp,
effectiveListenerSecurityProtocolMap, requireDistinctPorts=false)
} else {
- listeners
+ // Only use implicit broker listeners here. Implicit controller
listeners are handled in effectiveAdvertisedControllerListeners.
+ listeners.filterNot(l =>
controllerListenerNames.contains(l.listenerName.value()))
Review Comment:
Okay. It looks like the `advertisedListeners` method is not as useful as I
originally thought when I implemented it. If you agree, let's just remove the
method and inline the different implementations in
`effectiveAdvertisedBrokerListeners` and
`effectiveAdvertisedControllerListeners`. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
