jsancio commented on code in PR #18387:
URL: https://github.com/apache/kafka/pull/18387#discussion_r1966025315
##########
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##########
@@ -1230,6 +1230,44 @@ class KafkaConfigTest {
KafkaConfig.fromProps(props)
}
+ @Test
+ def
testImplicitAllBindingControllerListenersCanBeAdvertisedForKRaftController():
Unit = {
+ val props = new Properties()
+ props.setProperty(KRaftConfigs.PROCESS_ROLES_CONFIG, "controller")
+ val listeners = "CONTROLLER://:9093"
+ props.setProperty(SocketServerConfigs.LISTENERS_CONFIG, listeners)
+ props.setProperty(SocketServerConfigs.ADVERTISED_LISTENERS_CONFIG,
listeners) // explicitly setting it in KRaft
Review Comment:
Okay. Can you confirm that this is valid for the broker's advertise
listener? Ideally advertised listener should not contain unroutable hosts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
