AndrewJSchofield commented on code in PR #18824:
URL: https://github.com/apache/kafka/pull/18824#discussion_r1946301852
##########
server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java:
##########
@@ -356,16 +367,48 @@ public void onComplete(ClientResponse response) {
if (onCompleteCallback != null) {
onCompleteCallback.accept(response);
}
- if (response != null && response.hasResponse()) {
- if (isFindCoordinatorResponse(response)) {
+
+ // We don't know if FIND_COORD or actual REQUEST. Let's err on
side of request.
Review Comment:
Not even with lambda gymnatics like
https://github.com/apache/kafka/blob/da166b9dc1ba6476223eb19c267bd5e3babf7109/clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java#L152
?
##########
server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java:
##########
@@ -356,16 +367,48 @@ public void onComplete(ClientResponse response) {
if (onCompleteCallback != null) {
onCompleteCallback.accept(response);
}
- if (response != null && response.hasResponse()) {
- if (isFindCoordinatorResponse(response)) {
+
+ // We don't know if FIND_COORD or actual REQUEST. Let's err on
side of request.
Review Comment:
Not even with lambda gymnastics like
https://github.com/apache/kafka/blob/da166b9dc1ba6476223eb19c267bd5e3babf7109/clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java#L152
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
