smjn commented on code in PR #18824:
URL: https://github.com/apache/kafka/pull/18824#discussion_r1946332275
##########
server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java:
##########
@@ -356,16 +367,48 @@ public void onComplete(ClientResponse response) {
if (onCompleteCallback != null) {
onCompleteCallback.accept(response);
}
- if (response != null && response.hasResponse()) {
- if (isFindCoordinatorResponse(response)) {
+
+ // We don't know if FIND_COORD or actual REQUEST. Let's err on
side of request.
Review Comment:
Don't think so - in this impl, they are using another class `UnsentRequests`
which defines the callback where the response handler is sent.
InterBrokerSendThread defines its own `UnsentRequest` with no such cb.
Additionally, the InterBrokerSendThread.UnsentRequest is not exposed publically.
Btw, the only diff between the error handlers is a message - the response
type and err code are exactly the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
