mjsax commented on code in PR #18867:
URL: https://github.com/apache/kafka/pull/18867#discussion_r1952158053
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##########
@@ -450,23 +450,23 @@ public BranchedKStream<K, V> split(final Named named) {
}
@Override
- public KStream<K, V> merge(final KStream<K, V> stream) {
- return merge(stream, NamedInternal.empty());
+ public KStream<K, V> merge(final KStream<K, V> otherStream) {
+ return doMerge(builder, otherStream, NamedInternal.empty());
}
@Override
- public KStream<K, V> merge(final KStream<K, V> stream,
+ public KStream<K, V> merge(final KStream<K, V> otherStream,
final Named named) {
- Objects.requireNonNull(stream, "stream cannot be null");
- Objects.requireNonNull(named, "named cannot be null");
Review Comment:
unnecessary check -- happend in `doMerge` already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
